Re: Proposal: Disable autoload of compat_xyz modules

[Maxime Villard <max%m00nbsd.net@localhost>]

Le 16/09/2017 à 16:36, Christos Zoulas a écrit :
> On Sep 16,  4:15pm, max%m00nbsd.net@localhost (Maxime Villard) wrote:
> -- Subject: Re: Proposal: Disable autoload of compat_xyz modules
>
> | Le 13/09/2017 à 22:00, Christos Zoulas a écrit :
> | > Can't we add a sysctl that controls the behavior and have autoload
> | > of the compat modules off by default?
> |
> | Well, let's just do this. I've written (and tested) [1] - it works. A new
> | leaf is added in emul.linux, emul.linux.enabled={0,1}, which registers
> | linux_execsw.
> |
> | Obviously, after applying this patch we'll have to remove compat_linux from
> | the autoload array. And the same will have to be done in compat_linux32.
> |
> | Ok?
>
> Why? Leave it in the autoload, but fail to load it unless the sysctl is
> enabled...

Does not work, the leaf is added by the module itself, so you can't sysctl it
to 'enabled=1' unless the module is already loaded...

Maxime