tech-kern archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: Refactoring sc_audiochan



I've commited it.
If you have any comment, please contact here.

Thanks,
---
Tetsuya Isaki <isaki%pastel-flower.jp@localhost / isaki%NetBSD.org@localhost>

At Sun, 13 Aug 2017 14:22:22 +0900,
Tetsuya Isaki wrote:
> 
> Hi all,
> 
> In audio.c, sc_audiochan (list of struct audio_chan) is
> a mixed list of opened audio chan and first special element.
> 
> I want to split it for readability and performance.
> New sc_audiochan has opened audio chan only.
> Newly added sc_hwchan is what was the first special element.
> 
> However I found that everyone referring to sc_hwchan needs
> sc_hwchan->vc (struct virtual_channel), not sc_hwchan (struct
> audio_chan) itself.
> So it should be 'struct virtual_channel sc_hwvc',
> not 'struct audio_chan sc_hwchan'.
> 
> Then I have a question.  I think sc_hwvc is a good name to me
> but do you have better idea?
> I'll commit anyway if no opinions within a few days.
> 
> Thanks,
> ---
> Tetsuya Isaki <isaki%pastel-flower.jp@localhost / isaki%NetBSD.org@localhost>
> 
> Index: sys/dev/audio.c
> ===================================================================
> RCS file: /cvsroot/src/sys/dev/audio.c,v
> retrieving revision 1.393
> diff -u -r1.393 audio.c
:


Home | Main Index | Thread Index | Old Index