Re: CVS commit: src/sys/dev/scsipi

[Kengo NAKAHARA <k-nakahara%iij.ad.jp@localhost>]

Hi,

On 2017/06/19 23:16, Michael van Elst wrote:
> k-nakahara%iij.ad.jp@localhost (Kengo NAKAHARA) writes:
>> Today, I found my environment panic while rebooting. As bisecting, it
>> seems the cause is below commit.
> 
> Does the following patch help ?
> 
> Index: scsipi_base.c
> ===================================================================
> RCS file: /cvsroot/src/sys/dev/scsipi/scsipi_base.c,v
> retrieving revision 1.176
> diff -p -u -r1.176 scsipi_base.c
> --- scsipi_base.c	17 Jun 2017 22:35:50 -0000	1.176
> +++ scsipi_base.c	19 Jun 2017 14:14:58 -0000
> @@ -2403,7 +2403,7 @@ scsipi_target_detach(struct scsipi_chann
>  	device_t tdev;
>  	int ctarget, mintarget, maxtarget;
>  	int clun, minlun, maxlun;
> -	int error;
> +	int error = 0;
>  
>  	if (target == -1) {
>  		mintarget = 0;
> @@ -2453,7 +2453,7 @@ scsipi_target_detach(struct scsipi_chann
>  out:
>  	KERNEL_UNLOCK_ONE(curlwp);
>  
> -	return 0;
> +	return error;
>  }
>  
>  /*

This patch fix my problem. Thank you!


Thanks,

-- 
//////////////////////////////////////////////////////////////////////
Internet Initiative Japan Inc.

Device Engineering Section,
IoT Platform Development Department,
Network Division,
Technology Unit

Kengo NAKAHARA <k-nakahara%iij.ad.jp@localhost>