tech-kern archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Bogus comment about dkwedge_list() [sys/dev/dkwedge/dk.c]



The lead-in comment for dkwedge_list() is ...

/*      
 * dkwedge_list:        [exported function]
 *      
 *      List all of the wedges on a particular disk.
 *      If p == NULL, the buffer is in kernel space.  Otherwise, it is
 *      in user space of the specified process.
 */

There is no "p".

There is an lwp * paameter (l), but that one is not allowed to be NULL.

The function doesn't seem to care at all whether the buffer is in user or
kernel space  -- it just does:
	        uio.uio_vmspace = l->l_proc->p_vmspace;

The trailing two lines of the comment (starting with "If p == NULL,")
should just be deleted I suspect.

If someone really wants a PR for this, I could make one, but really...

kre



Home | Main Index | Thread Index | Old Index