tech-kern archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: xhci patch 20150623



Hello,

I fixed a bug that xhci_close_pipe caused mutex lock error
as close method is called with sc_lock held.


--- src/sys/dev/usb/xhci.c.orig	2015-06-27 01:08:34.000000000 +0900
+++ src/sys/dev/usb/xhci.c	2015-07-15 05:20:26.000000000 +0900
@@ -1583,7 +1583,7 @@ xhci_close_pipe(struct usbd_pipe *pipe)
 	trb.trb_3 = XHCI_TRB_3_SLOT_SET(xs->xs_idx) |
 	    XHCI_TRB_3_TYPE_SET(XHCI_TRB_TYPE_CONFIGURE_EP);
- (void)xhci_do_command(sc, &trb, USBD_DEFAULT_TIMEOUT);
+	(void)xhci_do_command_locked(sc, &trb, USBD_DEFAULT_TIMEOUT);
 	usb_syncmem(&xs->xs_dc_dma, 0, sc->sc_pgsz, BUS_DMASYNC_POSTREAD);
 }

regards,
--
t-hash


Home | Main Index | Thread Index | Old Index