sys/clock.h finalization

["Kamil Rytarowski" <n54%gmx.com@localhost>]

Hello,

Please let finalize src/sys/sys/clock.h:

1. Please review and add man page to src/share/man/man9
Thomas K. is responsible for man pages according to src/doc/RESPONSIBLE

2. src/tools/compat/dev/clock_subr.h defines:

/* Some handy constants. */
#define SECDAY          (24 * 60 * 60)
#define SECYR           (SECDAY * 365)

/* Traditional POSIX base year */
#define POSIX_BASE_YEAR 1970

Please nuke them, as these defines are now in src/sys/sys/clock.h and they aren't needed/used elsewhere.

3. src/sys/dev/clock_subr.c

Please change this code from clock_secs_to_ymdhms():
        /* Hours, minutes, seconds are easy */
        dt->dt_hour = rsec / 3600;
        rsec = rsec % 3600;
        dt->dt_min  = rsec / 60;
        rsec = rsec % 60;
        dt->dt_sec  = rsec;

to:
        /* Hours, minutes, seconds are easy */
        dt->dt_hour = rsec / SECS_PER_HOUR;
        rsec = rsec % SECS_PER_HOUR;
        dt->dt_min  = rsec / SECS_PER_MINUTE;
        rsec = rsec % SECS_PER_MINUTE;
        dt->dt_sec  = rsec;

Regards,

Attachment: clock.9
Description: Binary data