tech-kern archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: Vnode API change: add global vnode cache



Taylor R Campbell <campbell+netbsd-tech-kern%mumble.net@localhost> wrote:
>    Date: Mon, 7 Apr 2014 17:27:01 +0100
>    From: Mindaugas Rasiukevicius <rmind%netbsd.org@localhost>
> 
>    Should be fine, but once tmpfs is switched to use vcache, it might
> become a little bit more visible for some workloads..
> 
> Why switch tmpfs to use vcache?  That would add memory and time
> overhead for no reason.  struct tmpfs_node already has a map from key
> to vnode -- the tn_vnode field.  No need to manage an rb tree to
> accomplish the same thing.

Err.. yes.  I seem to forget conceptual details quickly after not working
on a codebase for a while.  We have in-memory inodes after all, duh! :)

-- 
Mindaugas


Home | Main Index | Thread Index | Old Index