tech-kern archive
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
Re: compat_netbsd32 swapctl
On Wed, Jan 29, 2014 at 05:45:51PM +0000, David Holland wrote:
> On Wed, Jan 29, 2014 at 03:37:13PM +0000, Emmanuel Dreyfus wrote:
> > + panic("unexpected cmd = %d", SCARG(&ua, cmd));
>
> panic on garbage from userland really isn't the ticket.
ok, so that is actually checked earlier; ergo
1. please write it as a KASSERT
2. don't write it in terms of SCARG values
to avoid violating least surprise.
--
David A. Holland
dholland%netbsd.org@localhost
Home |
Main Index |
Thread Index |
Old Index