tech-kern archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: extended attributes and lsextattr/extattr_list_file

On Wed, Jun 29, 2011 at 09:31:33AM +0000, Emmanuel Dreyfus wrote:
> The conversion is easy to do, but the right place to do it is tricky. 
> VOP_LISTEXTATTR() writes its output to the userland buffer, therefore if
> I convert in src/sys/ufs/ufs/ufs_extattr.c, I have to copyin/convert/copyout,
> and that does not looks good perfromance-wise. 

That would be trully horrid - rather reminds me of the stackgap ...
> Converting in libc is another option,

Does libc need to use its own buffer - or would that force it to allocate
a temporary buffer?
I've NFI how this data is used.

> and we can also add a flavor flag to 
> VOP_LISTEXTATTR so that we can require the filesystem to output the data
> in the appropriate format.

That seems more appropriate.


David Laight:

Home | Main Index | Thread Index | Old Index