Re: sys/dev/isa/fd.c FDUNIT/FDTYPE

[jnemeth%victoria.tc.ca@localhost (John Nemeth)]

On Sep 24,  6:14pm, Izumi Tsutsui wrote:
} > On Wed, May 04, 2011 at 08:50:10PM +0900, Izumi Tsutsui wrote:
} > > The problem is that there might be some ports whose MAXPARTITIONS is 
still 8
} > > and such ports can't use type 8.
} > 
} > Why not? It is not used as a partiton of fd*.
} > MAKEDEV is already wrong for those ports, the fd nodes probably should have
} > special case handling.
} 
} On i386:
} ---
} % ls -l fd1*
} brw-r-----  1 root  operator  2,      8 May  7  2003 fd1a
} [snip]
} brw-r-----  1 root  operator  2,     15 May  7  2003 fd1h
} brw-r-----  1 root  operator  2, 524296 May  7  2003 fd1i
} [snip]
} brw-r-----  1 root  operator  2, 524303 May  7  2003 fd1p
} ---
} 
} on amd64:
} ---
} # ls -l fd1*
} brw-r-----  1 root  operator  2, 16 May  4 23:31 fd1a
} [snip]
} brw-r-----  1 root  operator  2, 31 May  4 23:31 fd1p
} # 
} ---
} 
} So current isa/fd.c can't handle the second drive
} on ports where (MAXPARTITIONS != 8 && !__HAVE_OLD_DISKLABEL).
} 
} For compatibility with longstanding inconsistent MAKEDEV(8),
} it might be better to use DISKUNIT() and DISKPART() for
} FDUNIT() and FDTYPE() as other disks, so that we don't have
} to have special device minor handling for each MD fd device in
} MI MAKEDEV.tmpl script.

     So, instead of fixing the very broken MAKEDEV script, you want to
mangle multiple floppy drivers?  At the end of the day, MAKEDEV is
broken, it should not be treating floppy drives like hard drives.  The
unit letters don't have the same meaning and never have.

}-- End of excerpt from Izumi Tsutsui