Re: Using coccinelle for (quick?) syntax fixing

[Matthias Drochner <M.Drochner%fz-juelich.de@localhost>]

jeanyves.migeon%free.fr@localhost said:
> But the NULL deref fixes will go in eventually, and I will probably
> ask for a pull up too ;)

But then...

        algo = esp_algorithm_lookup(sav->alg_enc);
-       if (!algo) {
+       if (algo == NULL) {
                ipseclog((LOG_ERR,
-                   "esp_cbc_mature %s: unsupported algorithm.\n", algo->name));
+                   "esp_cbc_mature: NULL is not a valid algorithm.\n"));
                return 1;

The new error message if not helpful. How about printing alg_enc
instead which is in a well-defined namespace.

best regards
Matthias



------------------------------------------------------------------------------------------------
------------------------------------------------------------------------------------------------
Forschungszentrum Juelich GmbH
52425 Juelich
Sitz der Gesellschaft: Juelich
Eingetragen im Handelsregister des Amtsgerichts Dueren Nr. HR B 3498
Vorsitzender des Aufsichtsrats: MinDirig Dr. Karl Eugen Huthmacher
Geschaeftsfuehrung: Prof. Dr. Achim Bachem (Vorsitzender),
Dr. Ulrich Krafft (stellv. Vorsitzender), Prof. Dr.-Ing. Harald Bolt,
Prof. Dr. Sebastian M. Schmidt
------------------------------------------------------------------------------------------------
------------------------------------------------------------------------------------------------