tech-kern archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Add NULL power handler to x86/ipmi(4)



Is there any reason anyone can think of to not add a NULL power handler to the ipmi(4) driver? I can't see any reason for anything special to happen either at suspend or resume, and the lack of a power handler prevents the system from going to sleep at all.

Proposed patch is attached.

-------------------------------------------------------------------------
| Paul Goyette     | PGP Key fingerprint:     | E-mail addresses:       |
| Customer Service | FA29 0E3B 35AF E8AE 6651 | paul at whooppee.com    |
| Network Engineer | 0786 F758 55DE 53BA 7731 | pgoyette at juniper.net |
| Kernel Developer |                          | pgoyette at netbsd.org  |
-------------------------------------------------------------------------
Index: ipmi.c
===================================================================
RCS file: /cvsroot/src/sys/arch/x86/x86/ipmi.c,v
retrieving revision 1.46
diff -u -p -r1.46 ipmi.c
--- ipmi.c      10 Apr 2010 19:02:39 -0000      1.46
+++ ipmi.c      16 Jul 2010 12:19:09 -0000
@@ -1934,6 +1934,10 @@ ipmi_thread(void *cookie)
        sc->sc_wdog.smw_tickle = ipmi_watchdog_tickle;
        sysmon_wdog_register(&sc->sc_wdog);
 
+       /* Set up a NULL power handler so we can possibly sleep */
+       if (!pmf_device_register(self, NULL, NULL))
+                aprint_error_dev(self, "couldn't establish a power handler\n");
+
        mutex_enter(&sc->sc_poll_mtx);
        while (sc->sc_thread_running) {
                ipmi_refresh_sensors(sc);


Home | Main Index | Thread Index | Old Index