Re: brk(3)/break(2) does not fail for very high adresses

[Joerg Sonnenberger <joerg%britannica.bec.de@localhost>]

On Wed, Nov 25, 2009 at 11:59:29AM +0100, Nicolas Joly wrote:
> Index: sys/uvm/uvm_unix.c
> ===================================================================
> RCS file: /cvsroot/src/sys/uvm/uvm_unix.c,v
> retrieving revision 1.41
> diff -u -p -r1.41 uvm_unix.c
> --- sys/uvm/uvm_unix.c        4 Mar 2009 21:52:38 -0000       1.41
> +++ sys/uvm/uvm_unix.c        25 Nov 2009 10:58:40 -0000
> @@ -86,7 +86,8 @@ sys_obreak(struct lwp *l, const struct s
>       mutex_enter(&p->p_auxlock);
>       old = (vaddr_t)vm->vm_daddr;
>       new = round_page((vaddr_t)SCARG(uap, nsize));
> -     if ((new - old) > p->p_rlimit[RLIMIT_DATA].rlim_cur && new > old) {
> +     if ((SCARG(uap, nsize) && new == 0) ||

SCARG(uap, nsize) == 0 ==> new == 0, doesn't it?

> +         ((new - old) > p->p_rlimit[RLIMIT_DATA].rlim_cur && new > old)) {
>               mutex_exit(&p->p_auxlock);
>               return (ENOMEM);
>       }

Joerg