Re: CVS commit: src/external/gpl2/lvm2/dist/libdm/ioctl

[yamt%mwd.biglobe.ne.jp@localhost (YAMAMOTO Takashi)]

hi,

> Module Name:  src
> Committed By: haad
> Date:         Fri Jun  5 19:57:25 UTC 2009
> 
> Modified Files:
>       src/external/gpl2/lvm2/dist/libdm/ioctl: libdm-nbsd-iface.c
>           libdm_netbsd.c
> 
> Log Message:
> Parse dm param string in libdevmapper and not in a dm target init function.
> Create proplib param dictionary entry in libdevmapper and pass it to dm in
> dm_ioctl dict.
> Param target is then passed to target init function, where is parse. I like
> this aproach much better than passing char **argv and trusting to user input.

does it mean that libdevmapper now needs to know every targets?
if so, i don't think it's a good idea.

YAMAMOTO Takashi

> 
> XXX. Add more sanity checks in kernel.
> 
> 
> To generate a diff of this commit:
> cvs rdiff -u -r1.1 -r1.2 \
>     src/external/gpl2/lvm2/dist/libdm/ioctl/libdm-nbsd-iface.c \
>     src/external/gpl2/lvm2/dist/libdm/ioctl/libdm_netbsd.c
> 
> Please note that diffs are not public domain; they are subject to the
> copyright notices on the relevant files.