Re: More duplicate code, vnode locking question

[Andrew Doran <ad%netbsd.org@localhost>]

On Tue, Apr 21, 2009 at 12:25:32AM +0300, Elad Efrat wrote:

> However, this time vnode locking is involved, and I'm not sure what
> the rules are about functions that are not in the vnode interface
> (vnode_if?) that lock/unlock vnodes.

- the vnode must always be locked for VOP_ACCESS().
- the convention is that devvp is not held locked across mount.

> Also, it seems that some file-systems call VOP_OPEN() without devvp
> being locked. Compare, for example, ffs_mount() and efs_mount(). Is
> this possible, or am I missing something? :)

This is a bug.