tech-kern archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

suggested patch



While building a custom kernel with drm (radeondrm, in particular) configured, but with vga only at pci (ie, no agp), I discovered drm's "option DRM_NO_AGP" is required to avoid a number of linker errors.

Enabling this option in the kernel config resolved all but one of the link errors. The following patch resolves the final error. This is certainly not within my area of expertise, so I've not committed this without some level of discussion/confirmation that this is the right thing to do.

Comments appreciated...


Index: ati_pcigart.c
===================================================================
RCS file: /cvsroot/src/sys/dev/pci/drm/ati_pcigart.c,v
retrieving revision 1.7
diff -u -p -r1.7 ati_pcigart.c
--- ati_pcigart.c       18 Mar 2009 16:00:19 -0000      1.7
+++ ati_pcigart.c       16 Apr 2009 17:47:20 -0000
@@ -99,7 +99,9 @@ int drm_ati_pcigart_init(drm_device_t *d
                }
        }

+#ifndef DRM_NO_AGP
        agp_flush_cache();
+#endif

        return 1;
 }

-------------------------------------------------------------------------
|   Paul Goyette   | PGP DSS Key fingerprint: |  E-mail addresses:      |
| Customer Service | FA29 0E3B 35AF E8AE 6651 |  paul at whooppee.com   |
| Network Engineer | 0786 F758 55DE 53BA 7731 | pgoyette at juniper.net |
| Kernel Developer |                          | pgoyette at netbsd.org  |
-------------------------------------------------------------------------


Home | Main Index | Thread Index | Old Index