tech-kern archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: makesyscalls.sh off_t padding check problem for compat linux



In article <20080326213233.GI10654%snowdrop.l8s.co.uk@localhost>,
David Laight  <david%l8s.co.uk@localhost> wrote:
>On Sat, Mar 22, 2008 at 11:42:34AM +0100, Nicolas Joly wrote:
>> 
>> Hi,
>> 
>> For quite some tine now, comat linux syscalls files cannot be
>> generated anymore (at least for some ports). The problem comes from
>> makesyscalls.sh off_t padding check ...
>> 
>> Some compat linux syscalls currently use off_t arguments, but does not
>> have any padding ... this makesyscalls.sh fails its job.
>> 
>>      int linux_sys_truncate64(const char *path, off_t length);
>> 
>> Don't this check need to be restricted to native syscalls ?
>
>Actually it applies to certain architectures (ie 32bit ones that align
>64bit integer arguments).  Since netbsd uses the same kernel layout
>for all architectures it always applies to netbsd.
>
>Since the files are built separately from any build, the alignment
>rule needs to be enabled/disabled from the control file.
>
>Since, for example, any sparc system will need it (and probably ppc)
>checking for SYS_ isn't really right.

This is what I did, a while ago.

christos



Home | Main Index | Thread Index | Old Index