Subject: Re: pmap_phys_address()
To: Michael Lorenz <macallan@netbsd.org>
From: Allen Briggs <briggs@netbsd.org>
List: tech-kern
Date: 07/16/2007 09:59:28
On Mon, Jul 16, 2007 at 12:35:48AM -0400, Michael Lorenz wrote:
> pmap_phys_address() is used to translate tokens returned by mmap*() 
> methods to actual physical addresses - usually just a shift or a nop. 
> The problem is, in uvm_pmap.h it's declared with an int as argument 
> which will cause serious problems on 64bit architectures and possibly 
> on some 32bit archs as well.
> For sanity's sake I hereby propose to change its parameter to paddr_t 
> since that's what it's fed from all mmap*() methods.

Seems reasonable to me.

-allen

-- 
Allen Briggs  |  http://www.ninthwonder.com/~briggs/  |  briggs@ninthwonder.com