Subject: pmap_phys_address()
To: NetBSD tech-kern mailing list <tech-kern@netbsd.org>
From: Michael Lorenz <macallan@netbsd.org>
List: tech-kern
Date: 07/16/2007 00:35:48
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hello,

pmap_phys_address() is used to translate tokens returned by mmap*() 
methods to actual physical addresses - usually just a shift or a nop. 
The problem is, in uvm_pmap.h it's declared with an int as argument 
which will cause serious problems on 64bit architectures and possibly 
on some 32bit archs as well.
For sanity's sake I hereby propose to change its parameter to paddr_t 
since that's what it's fed from all mmap*() methods.

have fun
Michael
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (Darwin)

iQEVAwUBRpr1pMpnzkX8Yg2nAQKY3wf/dwcP4oHcd6Nj+zHWZIjLNVI3TZ5qbU1m
BLGeIPNCXR9x3bNqimyqbSfARigufGke2Zf1wKbPCkBkcJRq2H50y+03XFHdd94g
6aCMCBIIh2OT7auGsbR2M8tbLINrpPUp1lXCXfRywYZ/QFkttCblvxkhcPttF9X0
Z1v4BbkrSfd8c2fFFpg7TEpIJlOjTu7+l4xzG8tmWoFe1AaIs7crLSyYF9P4nb7P
QLCedEWgHeEvdnRchLI/vCBpcRBa4bQ4MqfYU/oQ4yPClKS7Qiyc+lut4RgoNIIC
lununfHjoXmlM+HxiM3Y5xNdVeSyfaUT3F4aZQcMS8pNCd19Uxc5mw==
=eDOe
-----END PGP SIGNATURE-----