Subject: Re: Latest bootprops patch (4)
To: Jared D.McNeill <jmcneill@invisible.ca>
From: Juan RP <juan@xtrarom.org>
List: tech-kern
Date: 06/21/2007 13:56:09
On Thu, 21 Jun 2007 07:00:03 -0400
Jared D. McNeill <jmcneill@invisible.ca> wrote:

> New in this patch, the ability to select PCI_*_FIXUP options at  
> runtime. The default values are determined by whether or not the  
> option is present in the kernel, so in the event that persistent  
> bootprops are not used, the kernel will fall back to traditional  
> behavior.
> 
> 	http://www.invisible.ca/~jmcneill/netbsd/bootprops4.patch

In the KOPT_DEFAULT_BOOL() macro, you can simplify this line:

+	prop_dictionary_set(_kopt, (k), prop_bool_create((v)));	

With:

prop_dictionary_set_bool(), so that you don't need to create the object
and make it a prop_bool_t.

-- 
Juan Romero Pardines	- The NetBSD Project
http://plog.xtrarom.org	- NetBSD/pkgsrc news in Spanish