Subject: Re: IPF in our source tree
To: Martti Kuparinen <martti.kuparinen@iki.fi>
From: Bill Stouder-Studenmund <wrstuden@netbsd.org>
List: tech-kern
Date: 06/01/2007 09:52:37
--gKMricLos+KVdGMg
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Jun 01, 2007 at 12:59:22PM +0300, Martti Kuparinen wrote:
>=20
> - Some fuctions (e.g. fr_sttab_destroy) were converted from the old K&R(?)
>   style to the new ANSI(?) C style. Why? There are still functions using
>   the old style. Any objections if I revert back to the original version?

The big problem with K&R style is it assumes everything fits in an int.=20
Since our LP64 systems are LP64I32, that means passing longs and pointers=
=20
is problematic.

To be honest, I know that's why K&R function declarations are bad. I'm not=
=20
100% sure what happens if you have an ANSI prototype and a K&R function=20
start.

So yes, I here by object to reverting to K&R functions. :-)

Take care,

Bill

--gKMricLos+KVdGMg
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.3 (NetBSD)

iD8DBQFGYE7VWz+3JHUci9cRAiWWAJ4itBxmKBQsiVTq/U4ztm1Y4uhBUwCdF/PC
PFKz6UHC8bLQiCjg/iVsaLc=
=Gd3v
-----END PGP SIGNATURE-----

--gKMricLos+KVdGMg--