Subject: bge query
To: None <tech-kern@netbsd.org>
From: Patrick Welche <prlw1@newn.cam.ac.uk>
List: tech-kern
Date: 05/17/2007 12:40:29
Looking at if_bgereg.h,v 1.41 (against FreeBSD), there seems to be a typo:

#define BGE_HCC_TX_COAL_TICKS_INT       0x3C1C /* ticks during interrupt */
#define BGE_HCC_RX_MAX_COAL_BDS_INT     0x3C20 /* BDs during interrupt */
#define BGE_HCC_TX_MAX_COAL_BDS_INT     0x3C34 /* BDs during interrupt */
#define BGE_HCC_STATS_TICKS             0x3C28
#define BGE_HCC_STATS_ADDR_HI           0x3C30
#define BGE_HCC_STATS_ADDR_LO           0x3C34

BGE_HCC_TX_MAX_COAL_BDS_INT should be 0x3C24 if it follows the sequence.

I thought that maybe it wasn't used, so no one would notice, but

bge_blockinit():
    CSR_WRITE_4(sc, BGE_HCC_RX_MAX_COAL_BDS_INT, 0);
    CSR_WRITE_4(sc, BGE_HCC_TX_MAX_COAL_BDS_INT, 0);

so maybe it does matter?

Cheers,

Patrick