Subject: Re: envsys version 2 API
To: Juan RP <juan@xtrarom.org>
From: Jason Thorpe <thorpej@shagadelic.org>
List: tech-kern
Date: 04/24/2007 14:40:39
On Apr 24, 2007, at 1:26 PM, Juan RP wrote:

> I've converted aiboost(4), if you are interested in the XML output
> that envstat(8) will parse:
>
> http://www.xtrarom.org/~juan/envsys2/output.txt

Couple of comments:

1- Overall, looks pretty good!

2- Are all the keys in the "aiboost0" dictionary "sensor0" ..  
"sensorN"?  And will all of the drivers report them this way?  If so,  
then it is probably best for that object to be an array, e.g.:

	<key>aiboost0</key>
	<array>
		<dict>
			<key>cur-value</key>
			<integer>313150000</integer>
			.
			.
			.
		</dict>
		.
		.
		.
	</array>

3- Eliminate the leading and trailing whitespace in your descriptions,  
e.g.:

	<key>description</key>
	<string> +3.3 Voltage</string>

should be:

	<key>description</key>
	<string>+3.3 Voltage</string>

4- Why do we have the driver name that provides the sendors at the top- 
level?  The idea is for sysmon to be the one place where all that  
information is gathered, rending the driver that provides it largely  
irrelevant, from the user's perspective.

-- thorpej