Subject: Re: wscons versus z8530tty
To: Julian Coleman <jdc@coris.org.uk>
From: Michael Lorenz <macallan@netbsd.org>
List: tech-kern
Date: 02/08/2007 14:51:48
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Hello,
On Feb 8, 2007, at 14:26, Julian Coleman wrote:
>> Err, zstty does that even if it's not the console? I'd call that a
>> bug.
>
> Well, we call zstty_attach() and we've set the ZS_HWFLAG_CONSOLE_INPUT
> flag,
> so it does assume that it's the console. I'd agree that there's a bug
> but
> I don't know if the best place to fix it is in the calling (sparc)
> code or
> in the zstty code.
Whatever sets the we-are-console-flag got it wrong this time. If zstty
just does what it's told then the bug is somewhere else.
> I'm starting to think that fixing the sparc code would make more sense
> -
> don't set the console-related zst_hwflags if we are using wscons.
> However,
> I'm still not 100% convinced, so I'm open to suggestions ;-)
Sounds like the right thing to do to me. Whatever determines wether a
device is console needs a re-work. On sparc64 and macppc we just ask OF
but I guess that's more complicated on sun4 :/
have fun
Michael
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (Darwin)
iQEVAwUBRct/VMpnzkX8Yg2nAQL/pggAhI+zTOfx2kaoZ+gvVHWN8dfsDZwudIDB
k5XwLzx2FyIDsKc1IVFwpD52gistRCW9Pa8oVJ3U2MPzz9LcjYVBQxsprW4UKi8F
SoYyXYyUJyS2u4Ohob98kOsPH2sBBlmK+yJYVnprZE2xcTkuZzQ5xEja9r6s5mcr
FZmnV35BtUAG65827X6x9s7KMhckfOcGEmlRxHWbK6g3PrKXPUhnDheprSv73vMW
3brbbQQ5xcKrHGGToEUQmDjubJ9FIPbnIq+X8kytLYNpqWbtW7Bk28zzDVM3acp0
DBZ99umDmlQMPDGYVnghUtb2nfa2TfquDk6K3bLFD2WUq6cvT83JlA==
=SL9Y
-----END PGP SIGNATURE-----