Subject: Re: bug in cbb power reactivation (patch)
To: None <tech-kern@NetBSD.org>
From: David Young <dyoung@pobox.com>
List: tech-kern
Date: 04/17/2006 23:24:37
On Mon, Apr 17, 2006 at 12:48:11AM -0600, M. Warner Losh wrote:
> In message: <20060417035541.GI1787@che.ojctech.com>
> David Young <dyoung@pobox.com> writes:
> : I have attached a patch that makes pccbb_power() consume the power-cycle
> : event *always*, even on a powerup->powerdown transition. Also, it DTRT
> : before interrupts have been enabled. Comments, please.
>
> How extensively have you tested these changes? When I did similar
> work for FreeBSD, I discovered what appeared to be bridges that did
> give a power-up interrupt, but didn't give a power-off interrupt. Now
> it is possible that I did something wrong, but when running the code
> on some machines (TI based) it worked, and other machines (Ricoh
> based) it didn't. It would be prudent to at least test on TI bridges
> and on Ricoh bridges to make sure that these details are handled
> consistantly between them.
I have tested on TI bridges and on a non-Ricoh, non-TI bridge whose
brand name escapes me. I haven't tested on a Ricoh bridge. I will.
Dave
--
David Young OJC Technologies
dyoung@ojctech.com Urbana, IL * (217) 278-3933