Subject: Re: PCI_MAPREG_TYPE_ROM... or the lack of it
To: Garrett D'Amore <garrett_damore@tadpole.com>
From: Garrett D'Amore <garrett_damore@tadpole.com>
List: tech-kern
Date: 02/25/2006 07:39:29
Allen Briggs wrote:
> On Fri, Feb 24, 2006 at 07:43:01PM -0800, Garrett D'Amore wrote:
>   
>> Actually, it occurs to me that there is an easier way:
>>
>> PCI_MAPREG_TYPE_ROM could be defined the same as PCI_MAPREG_TYPE_MEM,
>> and the PCI register mapping code could look at the offset of the register.
>>
>> PCI_MAPREG_ROM is *always* 0x30.  That's probably a better way to do it.
>>     
>
> I agree.  I think it should be noted in the man page that
> PCI_MAPREG_TYPE_ROM is only valid for PCI_MAPREG_ROM.
>
> -allen
>
>   
Okay, I'm going to take that as the "official" word then.  Expect diffs
early next week. :-)

    - Garrett

-- 
Garrett D'Amore, Principal Software Engineer
Tadpole Computer / Computing Technologies Division,
General Dynamics C4 Systems
http://www.tadpolecomputer.com/
Phone: 951 325-2134  Fax: 951 325-2191