Subject: Re: Proposal about disklabels
To: Jason Thorpe <thorpej@shagadelic.org>
From: David Laight <david@l8s.co.uk>
List: tech-kern
Date: 12/18/2005 12:23:45
On Sat, Dec 17, 2005 at 08:58:27PM -0800, Jason Thorpe wrote:
>
> Reinoud's patch is somewhat reasonable...
> subr_disk_mbr.c:readdisklabel() is the only version of that function
> that does not return "no disk label" when no label is found, as far
> as I can tell.
>
> What, exactly, depends on the semantics of it NOT returning that
> message?
Since the message gets written to the console, you get an annoying message
every time you access a 'vnd' disk that contains a single filesystem,
a raidframe partition that isn't subdivided, or a CD or ....
You also don't actually want the lack of a disklablel to be an error either.
ah yes...
http://cvsweb.netbsd.org/bsdweb.cgi/src/sys/arch/i386/i386/Attic/disksubr.c.diff?r1=1.51&r2=1.52&f=h
David
--
David Laight: david@l8s.co.uk