Subject: Re: yamt-vop branch
To: YAMAMOTO Takashi <yamt@mwd.biglobe.ne.jp>
From: Chuck Silvers <chuq@chuq.com>
List: tech-kern
Date: 10/29/2005 08:10:03
hi,

I looked at the changes, I have just a few comments:

cd9660_setattr
	should just return EOPNOTSUPP immediately, the extra checks are silly.

ntfs_fsync
	should take a (void *) argument like all the other VOPs.

tmpfs_update
	should return void, since it can't fail.

ffs_*
	should just call ffs_* directly instead of UFS_*.

lfs_*
	should just call lfs_* directly instead of UFS_*.


-Chuck


On Sat, Oct 29, 2005 at 07:39:53PM +0900, YAMAMOTO Takashi wrote:
> as there is no known problem,
> i'll merge the branch shortly if no one objects.
> (maybe shortly == after a few days.)
> 
> YAMAMOTO Takashi