On 9/20/05, YAMAMOTO Takashi <yamt@mwd.biglobe.ne.jp> wrote:
> > > can't you test before commit?
> >
> > Of course; that's what I wanted to say.
>=20
> why not?

Sorry?  In the original mail, I intended to say that I was going to test
everything before committing, but I now realize that the sentence was
not clear enough to express this will.  I don't ever commit stuff without
testing, even for trivial changes; experience has taught me that this
practice very often results in brokenness.

> - don't hardcode AF_MAX in mountd_exports_list.
>   i don't think AF_MAX is appropriate.

OK.  Should I define a new constant or maybe try to handle dynamically
sized structures?  (Dunno how to do the latter yet.)

> - i'm not sure if vfsfeature is a good idea.
>   are there any possible users other than nfs?

I think it will be useful if we move more stuff out of specific file
systems into kernel generic parts.  I don't know yet if this will be
possible at all, but if this is not appropriate...  do you see any other
clean way to initialize the NFS stuff without having to put an '#ifdef
NFSSERVER' in the system code?  That will do the trick, but it is
kind of ugly and doesn't separate the NFS code from the VFS one.
That was the point of this vfsfeatures thing.

> - why didn't you remove vfs_checkexp member from vfsops?

I did the same as with the vfs_sysctl member, renamed by atatat@
to vfs_wassysctl.  I believe this was done for compatibility reasons
with binary modules... but... the older ones won't work correctly in
the new scheme anyway so we'd simply remove it.

> - what's the point of del_exports in send_umntall?

send_umntall is the SIGTERM signal handler.  Shouldn't mountd(8)
unexport all file systems on exit?  If not, why not?

> - can you use "diff -up"?

Sure.  Didn't know about '-p', but it looks interesting.

Thanks for the review.

--=20
Julio M. Merino Vidal <jmmv84@gmail.com>
http://www.livejournal.com/users/jmmv/
The NetBSD Project - http://www.NetBSD.org/