Subject: Re: apache2 threads (fwd)
To: Christos Zoulas <christos@astron.com>
From: Jonathan Stone <jonathan@Pescadero.dsg.stanford.edu>
List: tech-kern
Date: 09/16/2005 11:23:32
In message <dgf0ua$75l$1@sea.gmane.org>Christos Zoulas writes
>In article <Pine.LNX.4.61.0509151958180.32033@m24s24.vlinux.de>,
>We should pull up the following to 3.0.
[...]
>@@ -538,7 +551,13 @@
> }
> sigemptyset(&p->p_sigctx.ps_sigcatch);
> p->p_sigctx.ps_sigwaited = NULL;
>- p->p_flag &= ~P_NOCLDSTOP;
>+
>+ /*
>+ * Reset no zombies if child dies flag as Solaris does.
>+ */
....
One small niggle: that added comment is very difficult to parse.
Adding some punctiution or quotes, e.g.,
/*
* Reset "no zombies if child dies" flag, as Solaris does.
*/
would help reability dramatically. (Rework if necessary to match what
you intended the comment to convey).
Can we do that before pulling up?
thx,
--Jonathan