Subject: Returning inode generation numbers
To: None <tech-kern@netbsd.org>
From: Julio M. Merino Vidal <jmmv84@gmail.com>
List: tech-kern
Date: 09/09/2005 12:22:04
------=_Part_1337_11152975.1126261324168
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

Hi all,

In revision 1.22 of sys/kern/vfs_vnops.c, the returning of inode
generation numbers to userland was removed and replaced by a
hardcoded 0 value.

This was probably done for security so that the user cannot predict
the next generation number.  But I don't see any reason to forbid
this value to the super-user.

The thing is that I want to access the generation number from
userland to write a regression test for tmpfs.  The test should
verify that when a node is reused, it gets a different number.
But there is actually no way to write this.

Is the attached patch correct?  Any objections in adding this feature?

Thanks,

--=20
Julio M. Merino Vidal <jmmv84@gmail.com>
http://www.livejournal.com/users/jmmv/
The NetBSD Project - http://www.NetBSD.org/

------=_Part_1337_11152975.1126261324168
Content-Type: text/x-patch; name="patch.diff"
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="patch.diff"

SW5kZXg6IHN5cy9rZXJuL3Zmc192bm9wcy5jCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9jdnNyb290
L3NyYy9zeXMva2Vybi92ZnNfdm5vcHMuYyx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS45NApkaWZm
IC11IC1yMS45NCB2ZnNfdm5vcHMuYwotLS0gc3lzL2tlcm4vdmZzX3Zub3BzLmMJMjMgSnVsIDIw
MDUgMTg6MTk6NTEgLTAwMDAJMS45NAorKysgc3lzL2tlcm4vdmZzX3Zub3BzLmMJOSBTZXAgMjAw
NSAwOTo1OToyNyAtMDAwMApAQCAtNTY1LDcgKzU2NSwxMCBAQAogCXNiLT5zdF9iaXJ0aHRpbWVz
cGVjID0gdmEudmFfYmlydGh0aW1lOwogCXNiLT5zdF9ibGtzaXplID0gdmEudmFfYmxvY2tzaXpl
OwogCXNiLT5zdF9mbGFncyA9IHZhLnZhX2ZsYWdzOwotCXNiLT5zdF9nZW4gPSAwOworCWlmIChw
LT5wX2NyZWQtPnBfcnVpZCA9PSAwKQorCQlzYi0+c3RfZ2VuID0gdmEudmFfZ2VuOworCWVsc2UK
KwkJc2ItPnN0X2dlbiA9IDA7CiAJc2ItPnN0X2Jsb2NrcyA9IHZhLnZhX2J5dGVzIC8gU19CTEtT
SVpFOwogCXJldHVybiAoMCk7CiB9CkluZGV4OiBsaWIvbGliYy9zeXMvc3RhdC4yCj09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT0KUkNTIGZpbGU6IC9jdnNyb290L3NyYy9saWIvbGliYy9zeXMvc3RhdC4yLHYKcmV0cmlldmlu
ZyByZXZpc2lvbiAxLjM0CmRpZmYgLXUgLXIxLjM0IHN0YXQuMgotLS0gbGliL2xpYmMvc3lzL3N0
YXQuMgkxNCBKdW4gMjAwNSAxMjoxMDowMiAtMDAwMAkxLjM0CisrKyBsaWIvbGliYy9zeXMvc3Rh
dC4yCTkgU2VwIDIwMDUgMDk6NTk6MjcgLTAwMDAKQEAgLTI5LDcgKzI5LDcgQEAKIC5cIgogLlwi
ICAgICBAKCMpc3RhdC4yCTguNCAoQmVya2VsZXkpIDUvMS85NQogLlwiCi0uRGQgTWF5IDEsIDE5
OTUKKy5EZCBTZXB0ZW1iZXIgOSwgMjAwNQogLkR0IFNUQVQgMgogLk9zCiAuU2ggTkFNRQpAQCAt
MjM2LDYgKzIzNiwxMSBAQAogLlBwCiBGb3IgYSBkZXNjcmlwdGlvbiBvZiB0aGUgZmxhZ3MsIHNl
ZQogLlhyIGNoZmxhZ3MgMiAuCisuU2ggTk9URVMKK1RoZSBpbm9kZSBnZW5lcmF0aW9uIG51bWJl
cgorLlZhICggc3RfZ2VuICkKK2lzIG9ubHkgYXZhaWxhYmxlIHRvIHRoZSBzdXBlci11c2VyLgor
UmVndWxhciB1c2VycyB3aWxsIGFsd2F5cyByZWNlaXZlIGEgemVybyBpbiB0aGlzIGZpZWxkLgog
LlNoIFJFVFVSTiBWQUxVRVMKIFVwb24gc3VjY2Vzc2Z1bCBjb21wbGV0aW9uIGEgdmFsdWUgb2Yg
MCBpcyByZXR1cm5lZC4KIE90aGVyd2lzZSwgYSB2YWx1ZSBvZiBcLTEgaXMgcmV0dXJuZWQgYW5k
Cg==
------=_Part_1337_11152975.1126261324168--