Subject: Re: Adding sysctl options to syncfs
To: Juan RP <juan@xtrarom.org>
From: Jonathan Stone <jonathan@Pescadero.dsg.stanford.edu>
List: tech-kern
Date: 09/06/2005 12:56:05
In message <59D467BE-7E5C-4643-A47D-43DB396C52A7@shagadelic.org>,
Jason Thorpe writes:

>
>On Sep 5, 2005, at 8:24 AM, Juan RP wrote:
>
>>
>> Hi, the following patch will add:
>>
>> ftp://ftp.NetBSD.org/pub/NetBSD/misc/xtraeme/syncfs_sysctl.diff
>>
>> [juan@Nocturno][~]> sysctl -a|grep syncfs
>> kern.syncfs.syncdelay = 30
>> kern.syncfs.filedelay = 30
>> kern.syncfs.dirdelay = 15
>> kern.syncfs.metadelay = 10
>> [juan@Nocturno][~]>
>
>How about vfs.syncfs ?

Better, but I submit that it really has to be:

		vfs.sync.delay.{sync,file,dir,meta}

v_fs_.sync_fs_ is redundant. If I'm correctly remembering an email
from Matt Thomas (about ipq sysctl), we avoid such redundancy in our
sysctl namespace.

No flames. I'm just trying to pass on collective wisdom.  I made the
same mistake myself when creating sysctl knobs, also inspired by
FreeBSD prior art.  Compare our *ipq* sysctl namespace to the FreeBSD
namespace, and you'll see my reasoning.