Reinoud Zandijk wrote:
> int kucopyin(int kernelspace, void *uaddr, void *kaddr, int len) {
> 	int retval;
> 
> 	if (!kernelspace) {
> 		return copyin(uaddr, kaddr, len);
> 	};

Bah. Please remove the semicolon.

> 
> 	/*
> 	 * returning anything other than 0 is meaningless for it would have 
> 	 * panicked the kernel allready if the address was not valid.
> 	 */
> 	kcopy(uaddr, kaddr, len);
> 	return 0;
> }

To make reading of the code easier, use as few negations as possible. I 
would reverse the "then" and the "else" part. According to 
/usr/share/misc/style, the braces around the "then" part should be removed.

Roland