Subject: Re: kern/25279: NFS read doesn't update atime
To: Steven M. Bellovin <smb@cs.columbia.edu>
From: Manuel Bouyer <bouyer@antioche.lip6.fr>
List: tech-kern
Date: 07/06/2005 16:50:38
On Wed, Jul 06, 2005 at 09:42:43AM -0400, Steven M. Bellovin wrote:
> >> as modifications are visible to the world at this point,
> >> "if (error == 0)" here doesn't make much sense.
> >
> >If genfs_gop_write() returned an error, it's possible that the data have not
> >been written, right ? Do we still want to update the mtime of the inode if
> >no data was written on disk ?
> >
>
> Yes, because the write operation may have partially succeeded.
The question is, should the mtime be updated on a partial write operation ?
Some data have changed, but it may not be complete.
--
Manuel Bouyer <bouyer@antioche.eu.org>
NetBSD: 26 ans d'experience feront toujours la difference
--