Subject: Re: kern/25279: NFS read doesn't update atime
To: None <bouyer@antioche.lip6.fr>
From: YAMAMOTO Takashi <yamt@mwd.biglobe.ne.jp>
List: tech-kern
Date: 06/30/2005 12:13:31
> +int
> +ufs_gop_write(struct vnode *vp, struct vm_page **pgs, int npages, int flags)
> +{
> + struct inode *ip = VTOI(vp);
> + int error;
> +
> + error = genfs_gop_write(vp, pgs, npages, flags);
> + if (error == 0) {
> + /* file has been written, update mtime */
> + ip->i_flag |= IN_CHANGE | IN_UPDATE;
> + }
> + return error;
> +}
as modifications are visible to the world at this point,
"if (error == 0)" here doesn't make much sense.
YAMAMOTO Takashi