Subject: Re: kern/25279: NFS read doesn't update atime
To: Manuel Bouyer <bouyer@antioche.lip6.fr>
From: Chuck Silvers <chuq@chuq.com>
List: tech-kern
Date: 06/28/2005 06:59:53
On Tue, Jun 28, 2005 at 11:55:39AM +0200, Manuel Bouyer wrote:
> Hi,
> so here is another patch, based on comments received:
> - it also updates the mtime on VOP_PUTPAGE()
as I mentioned before, I don't think this makes any sense.
timestamp updates should be associated with changes to a file's
logical contents, not with internal cache-flushing activity.
> - after fixing ufs_balloc_range() to not use VM_PROT_READ, test for
> VM_PROT_READ in VOP_GETPAGE() to see if we should update the atime or not
is sorta makes more sense to use VM_PROT_WRITE here instead of VM_PROT_READ,
since the overall operation of which this is a part is a write().
does that make the right things happen?
-Chuck