Subject: Re: Compressed vnd handling tested successfully
To: Hubert Feyrer <hubert@feyrer.de>
From: Jason Thorpe <thorpej@shagadelic.org>
List: tech-kern
Date: 06/14/2005 09:21:38
On Jun 13, 2005, at 4:40 AM, Hubert Feyrer wrote:
> Looking at the code, I wonder how to do this:
> * just add an #ifdef for a symbol around the code, and keep the
> data fields for compression handling in struct vnd_softc
> * put the #ifdef also on the fields in struct vnd_softc
> * use something else than an #ifdef/option (I have no idea on kernel
> hacking :)
Don't #ifdef the fields in the vnd_softc structure -- that would
change the ABI for kmem grovelers based on a kernel option.
>
> Thinking more about the userland tool's name, I wonder if
> "vndcompress" would be more appropriate than cl<something>...
Yes, that sounds better. Just mention which format it is compatible
with.
Thanks for taking up this effort!
>
>
> - Hubert
>
-- thorpej