Subject: Re: CVS commit: src/sys/fs/ntfs
To: Jaromir Dolecek <jdolecek@netbsd.org>
From: Bill Studenmund <wrstuden@netbsd.org>
List: tech-kern
Date: 04/10/2003 11:49:43
On Thu, 10 Apr 2003, Jaromir Dolecek wrote:

> Bill Studenmund wrote:
> > Only VOP_REMOVE and VOP_RDMIR need to worry about this, and it should be
> > easy to fix.
>
> Also VOP_RENAME, but that should work with the below change too.

No. From vnode.src:

vop_rename {
        IN WILLRELE struct vnode *fdvp;
        IN WILLRELE struct vnode *fvp;
        IN struct componentname *fcnp;
        IN WILLPUT struct vnode *tdvp;
        IN WILLRELE struct vnode *tvp;
        IN struct componentname *tcnp;
};

rename only has one WILLPUT, so we don't have to worry about a
dual-vput(). Or at least that was my thinking. :-)

> I'll give it a try and see if it works.

Thanks!

Take care,

Bill