Subject: Re: unconditional lfs_writefile for ifile?
To: None <perseant@netbsd.org>
From: YAMAMOTO Takashi <yamt@mwd.biglobe.ne.jp>
List: tech-kern
Date: 12/26/2002 23:05:24
hi

i'll commit this if no one objects.

thanks.

YAMAMOTO Takashi

> hi.
> 
> in lfs_segment.c rev.1.74, you commented out a if ()
> so that lfs_writefile is called for ifile unconditionally.
> what's your intention of this?
> 
> because lfs_writefile marks ifile IN_ACCESS, it'll be
> written unnecessarily in following lfs_writeinode.
> can i back out this part as following patch?
> 
> YAMAMOTO Takashi
> 
> 
> Index: lfs_segment.c
> ===================================================================
> --- lfs_segment.c	(revision 45)
> +++ lfs_segment.c	(working copy)
> @@ -636,7 +636,7 @@ lfs_segwrite(struct mount *mp, int flags
>  			fs->lfs_flags &= ~LFS_IFDIRTY;
>  
>  			ip = VTOI(vp);
> -			/* if (LIST_FIRST(&vp->v_dirtyblkhd) != NULL) */
> +			if (LIST_FIRST(&vp->v_dirtyblkhd) != NULL)
>  				lfs_writefile(fs, sp, vp);
>  			if (ip->i_flag & IN_ALLMOD)
>  				++did_ckp;