Subject: possible bugs in if_pcn.c ?
To: None <tech-kern@netbsd.org>
From: Erik Anggard <erik.anggard@packetfront.com>
List: tech-kern
Date: 10/22/2002 16:36:25
Hi,

I came across the following two lines (see patch below) when reading 
if_pcn.c that look a bit suspicious to me. (I'm not sure about the 
second one, I noted it only because it looks very similar to the line 
changed in revision 1.9->1.10). Maybe someone who has worked with 
if_pcn.c could take a look at it.

Best regards,
Erik Anggard


--- if_pcn.c.orig       Tue Oct 22 16:15:51 2002
+++ if_pcn.c    Tue Oct 22 16:15:02 2002
@@ -1641,7 +1641,7 @@
                 * our own MII layer.
                 */
                pcn_bcr_write(sc, LE_BCR32,
-                   pcn_csr_read(sc, LE_BCR32) | LE_B32_DANAS);
+                   pcn_bcr_read(sc, LE_BCR32) | LE_B32_DANAS);
        }
 
        /*
@@ -2030,7 +2030,7 @@
                        reg |= LE_B9_AUIFD;
                pcn_bcr_write(sc, LE_BCR9, reg);
        } else
-               pcn_bcr_write(sc, LE_BCR0, 0);
+               pcn_bcr_write(sc, LE_BCR9, 0);
 
        return (0);
 }