Subject: Re: timeout issue in scsi drivers: mstohz()
To: David Laight <david@l8s.co.uk>
From: Manuel Bouyer <bouyer@antioche.eu.org>
List: tech-kern
Date: 04/04/2002 22:22:40
On Thu, Apr 04, 2002 at 09:53:50PM +0200, Manuel Bouyer wrote:
> > #define mstohz(ms) \
> > 	(__predict_false((ms) >= 0x10000u) ? \
> > 	    ((ms) + 0u) / 1000u * hz : \
> > 	    ((ms) + 0u) * hz / 1000u)
> 

Is this enouth in case ms isn't an integer but something smaller (say
a char) ? Should (ms) be casted to (u_int) to be safe ?

-- 
Manuel Bouyer <bouyer@antioche.eu.org>
--