On Fri, May 25, 2001 at 11:43:07AM -0700, Matthew Jacob wrote:
> [...]
> But if you have to keep track....
> 
> 
> D'ya mind if I change the message here- you added the following
> to scsipi_channel_thaw:
> 
>         /*      
>          * Kick the channel's queue here.  Note, we may be running in
>          * interrupt context (softclock or HBA's interrupt), so the adapter
>          * driver had better not sleep.
>          */             
>         if (chan->chan_qfreeze == 0)
>                 scsipi_run_queue(chan);
> 
> 
> The whole point of a lot of this exercise is to be *able* to allow
> scspi_run_queue to be called from process context. How about:
> 
>         /*      
>          * Kick the channel's queue here.  Note, we may be running in interrupt
> 	 * context (softclock or HBA's interrupt), so the adapter driver had
>          * better not sleep (unless it's the adapter itself that called this
> 	 * function).
>          */             

Well it depends on how the adapter called this. If it called it from its
interrupt routine, no sleep allowed :)

--
Manuel Bouyer, LIP6, Universite Paris VI.           Manuel.Bouyer@lip6.fr
--