Subject: Re: PCI-audio & endianness (eso.c/mulaw.c)
To: None <eeh@one-o.com>
From: Izumi Tsutsui <tsutsui@ceres.dti.ne.jp>
List: tech-kern
Date: 10/28/1999 01:56:37
In <199910271617.JAA01770@jericho.one-o.com>
eeh@one-o.com wrote:

> > I think bswap32() should not be needed in bus_space(9) functions, too.
> 
> Huh?  bswap32() should be done inside the bus_space(9) macros if/when
> appropriate.  Drivers should not be involved in this at all.

Sorry, "should not be needed in bus_space(9) functions" is not correct.
It is "should not be used in bus_space(9) arguments." (as current eso.c does)

> The last two need to be handled by the device driver itself, which is
> rather unfortunate if the configuration consists of a big-endian CPU
> communicating with a big-endian device and this results in two
> completely redundant byte-swaps.

I totally agree.
---
Izumi Tsutsui
tsutsui@ceres.dti.ne.jp