Subject: Re: ISO-Image nitpicks
To: Luke Mewburn <lukem@NetBSD.org>
From: Martin Husemann <martin@duskware.de>
List: tech-install
Date: 03/03/2005 08:48:56
--2fHTh5uZTiUOsy+g
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Mar 03, 2005 at 08:15:39AM +1100, Luke Mewburn wrote:
>   |        -L     Allow ISO9660 filenames to begin  with  a  period.   Usually,
>   |               a leading dot is replaced with an underscore in order
>   |               to maintain MS-DOS compatibility. This violates the
>   |               ISO9660 standard, but it happens to work on many
>   |               systems. Use with caution.
> 
> How safe is this, and what benefit does it give on our current media?

NetBSD and win* have no problems with it; but I think it actually does
not change anything for our distrib CD right now (it's just in my set
of options I always use, so I mentioned it). I've removed it.

> This didn't work as expected because of the -v later in the args.
> When I put -quiet after -v I saw the intended effect, and I like it.
> You might as well replace -v with -quiet in MKISOFS_FLAGS, and
> possibly provide a method to allow people to easily append to
> MKISOFS_FLAGS if they want to add -v to increase verbosity.

Ok, like this?

Martin

--2fHTh5uZTiUOsy+g
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename=patch

Index: Makefile
===================================================================
RCS file: /cvsroot/src/etc/Makefile,v
retrieving revision 1.304
diff -u -r1.304 Makefile
--- Makefile	23 Feb 2005 02:10:33 -0000	1.304
+++ Makefile	3 Mar 2005 07:41:26 -0000
@@ -57,12 +57,15 @@
 MKISOFS?=	mkisofs
 DISTRIBREV!=	${HOST_SH} ${KERNSRCDIR}/conf/osrelease.sh -s
 # ISO 9660 volume ID.  Note that this can only contain [A-Z0-9_].
-ISO_VOLID!=	echo NETBSD_${MACHINE}_${DISTRIBREV} | tr a-z A-Z
-MKISOFS_FLAGS+= -J -l \
-		-r -T -v \
+ISO_VOLID!=	echo NETBSD_${DISTRIBREV} | tr a-z A-Z
+MKISOFS_FLAGS+= -J -l -hide-joliet-trans-tbl -r -T \
 		-V ${ISO_VOLID} \
 		-P "The NetBSD Project" \
 		-m "${RELEASEDIR}/${RELEASEMACHINEDIR}/installation/cdrom"
+.if ${MKISOFS_FLAGS:N-v}
+MKISOFS_FLAGS+=	-quiet
+.endif
+ 
 
 # MD Makefile.inc may append MD targets to BIN[123].  Make sure all
 # are empty, to preserve the old semantics of setting them below with "=".

--2fHTh5uZTiUOsy+g--