Source-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

CVS commit: src/sys/dev



Module Name:    src
Committed By:   riastradh
Date:           Mon Nov 16 20:20:35 UTC 2026

Modified Files:
        src/sys/dev: fss.c

Log Message:
fss(4): Rework creation path to avoid various races.

1. Look up each vnode exactly once; the identity of the vnode may
   change between lookups otherwise.

2. Don't read v_vflag or v_mount without holding the vnode lock;
   otherwise they may be changed by concurrent revoke.

3. Hold vfs_busy(mp) while we don't have one of its vnode's locked
   and we haven't committed the fss instance to FSS_ACTIVE (at which
   point fss_unmount_hook will take care of it).

4. Set sc->sc_uflags at the same time the transition to FSS_ACTIVE,
   and loosen assertion after fss_create_snapshot, to avoid a race
   between FSSIOCSET and FSSIOCCLR.  See comments in FSSIOCSET for
   details.

XXX Should consider using namei and VOP_REMOVE instead of
do_sys_unlink to remove only the vnode that we actually looked up,
not whatever might be there later.

PR kern/60986: fssconfig panics on bad backing store type


To generate a diff of this commit:
cvs rdiff -u -r1.121 -r1.122 src/sys/dev/fss.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.




Home | Main Index | Thread Index | Old Index