CVS commit: src/sys/dev/usb

["Emmanuel Dreyfus" <manu%netbsd.org@localhost>]

Module Name:    src
Committed By:   manu
Date:           Fri Oct 10 12:08:54 UTC 2025

Modified Files:
        src/sys/dev/usb: ucom.c

Log Message:
Fix ucom input queue corruption on open-after-close

When closing ucom(4) while a transfer was in progress, ucomreadcb()
is called with USBD_CANCELLED. Previously, the ucom_buffer was not
removed from sc->sc_ibuff_empty, leading to queue corruption when
reopening the device: ucomopen() calls ucomsubmitread(), which
queues the ucom_buffer again.

We fix this by making sure the ucom_buffer is removed from queue
on USBD_CANCELLED or USBD_IOERROR.

Approved by Nick Hudson, who rewrote the comment.


To generate a diff of this commit:
cvs rdiff -u -r1.141 -r1.142 src/sys/dev/usb/ucom.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.