CVS commit: src/usr.bin/make

["Simon J. Gerraty" <sjg%netbsd.org@localhost>]

Module Name:    src
Committed By:   sjg
Date:           Wed Jun 11 18:49:58 UTC 2025

Modified Files:
        src/usr.bin/make: make.h var.c
        src/usr.bin/make/unit-tests: cond-func-empty.exp cond-func-empty.mk

Log Message:
make: check variable names for invalid characters

Variable names should not contain white-space.
As is; make quietly ignores gmake syntax like
$(addprefix -I, $(INCLUDE_DIR_LIST))
which means we are not doing what the makefile wants, and the
user has no clue.

CheckVarname is called only if there are no modifiers to be applied
as :L and others legitimately can handle white-space,
it will issue a warning if illegal characters are found.
Currently only white-space is checked.

The NetBSD build produces a few warnings - in one case a makefile
intended for gmake, and the other some dubious constructs by bsd.prog.mk
in support of ATF tests such as OBJS.${PROG} when PROG is actually a list.

Reviewed by: rillig


To generate a diff of this commit:
cvs rdiff -u -r1.357 -r1.358 src/usr.bin/make/make.h
cvs rdiff -u -r1.1164 -r1.1165 src/usr.bin/make/var.c
cvs rdiff -u -r1.10 -r1.11 src/usr.bin/make/unit-tests/cond-func-empty.exp
cvs rdiff -u -r1.28 -r1.29 src/usr.bin/make/unit-tests/cond-func-empty.mk

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.