CVS commit: src

["Roland Illig" <rillig%netbsd.org@localhost>]

Module Name:    src
Committed By:   rillig
Date:           Thu Jun  5 21:56:54 UTC 2025

Modified Files:
        src/distrib/sets/lists/tests: mi
        src/usr.bin/make: main.c
        src/usr.bin/make/unit-tests: Makefile opt-jobs-internal.exp
            shell-csh.mk shell-ksh.exp shell-ksh.mk
Added Files:
        src/usr.bin/make/unit-tests: job-output.exp job-output.mk

Log Message:
make: remove empty line from diagnostic, add tests for output handling

The warning for the invalid internal option "-J" does not need a
trailing newline, as that is provided by Parse_Error already.

Having this newline in the output demonstrated a previously unknown bug
in handling the output of child commands in parallel mode. There, empty
lines are randomly discarded, depending on the chunks in which the
output from the child process is copied to make's stdout. See
job-output.mk for a demonstration.

The test for the Korn shell did not run the Korn shell in error handling
mode, as the error handling mode only affects the parallel mode but the
test didn't switch to that mode.

After fixing the shell-ksh.mk test, the single '"' in the output looked
suspicious, and indeed, the shell-csh.mk test had the same problem of
filtering more characters from the output than intended.


To generate a diff of this commit:
cvs rdiff -u -r1.1377 -r1.1378 src/distrib/sets/lists/tests/mi
cvs rdiff -u -r1.655 -r1.656 src/usr.bin/make/main.c
cvs rdiff -u -r1.362 -r1.363 src/usr.bin/make/unit-tests/Makefile
cvs rdiff -u -r0 -r1.1 src/usr.bin/make/unit-tests/job-output.exp \
    src/usr.bin/make/unit-tests/job-output.mk
cvs rdiff -u -r1.8 -r1.9 src/usr.bin/make/unit-tests/opt-jobs-internal.exp
cvs rdiff -u -r1.9 -r1.10 src/usr.bin/make/unit-tests/shell-csh.mk
cvs rdiff -u -r1.1 -r1.2 src/usr.bin/make/unit-tests/shell-ksh.exp \
    src/usr.bin/make/unit-tests/shell-ksh.mk

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.