CVS commit: src/sys/arch/mips/mips

["Taylor R Campbell" <riastradh%netbsd.org@localhost>]

Module Name:    src
Committed By:   riastradh
Date:           Thu Apr 24 12:54:43 UTC 2025

Modified Files:
        src/sys/arch/mips/mips: compat_13_machdep.c

Log Message:
mips: Fix compat_13_sys_sigreturn locking.

This had been broken back in rev. 1.13.20.1 (on the newlock2 branch,
merged into HEAD as 1.14) in 2007.

Should fix:

   lib/libc/setjmp/t_setjmp (261/985): 10 test cases
       _longjmp_zero: [0.078125s] Passed.
       _setjmp: [0.093750s] Passed.
       compat13_longjmp_zero: [ 7875.3945352] panic: kernel diagnostic assertion "mutex_owned(l->l_proc->p_lock)" failed: file "/tmp/build/2025.04.24.01.52.38-pmax/src/sys/kern/sys_sig.c", line 590
   [ 7875.3984415] cpu0: Begin traceback...
   [ 7875.4062540] pid -2135532376 not found
   [ 7875.4140665] cpu0: End traceback...
   [ 7875.6093790] 0x80b65c90: cpu_reboot+0x3c (0x80b64000,0,0x866e5400,0x805b6440) ra 0x803197c0 sz 24
   [ 7875.7109415] 0x80b65ca8: kern_reboot+0xb0 (0x80b64000,0,0x866e5400,0x805b6440) ra 0x80369c80 sz 40
   [ 7875.7109415] 0x80b65cd0: vpanic+0x1dc (0x80b64000,0,0x866e5400,0x805b6440) ra 0x804c085c sz 48
   [ 7875.7109415] 0x80b65d00: kern_assert+0x3c (0x80b64000,0x804e6a3c,0x8051f7a8,0x8052e330) ra 0x8038df4c sz 32
   [ 7875.7265665] 0x80b65d20: sigprocmask1+0x224 (0x80b64000,0x804e6a3c,0x8051f7a8,0x8052e330) ra 0x800616f0 sz 48
   [ 7875.7265665] 0x80b65d50: compat_13_sys_sigreturn+0x1f0 (0x80b64000,0x804e6a3c,0x8051f7a8,0x8052e330) ra 0x80055178 sz 376
   [ 7875.7265665] 0x80b65ec8: syscall+0x158 (0x80b64000,0x804e6a3c,0x8051f7a8,0x8052e330) ra 0x800450ac sz 128
   [ 7875.7265665] 0x80b65f48: mips1_systemcall+0xec (0x80b64000,0x804e6a3c,0x8051f7a8,0x8052e330) ra 0x7923d090 sz 0
   [ 7875.7265665] PC 0x7923d090: not in kernel space
   [ 7875.7265665] 0x80b65f48: 0+0x7923d090 (0x80b64000,0x804e6a3c,0x8051f7a8,0x8052e330) ra 0 sz 0
   [ 7875.7265665] User-level: pid 17290.17290

https://releng.netbsd.org/b5reports/pmax/2025/2025.04.24.01.52.38/test.log

(Probably won't do anything about `pid -2135532376 not found',
though!)

Prompted by adding tests for compat13 for:

PR port-mips/59285: _longjmp(..., 0) makes setjmp return 0, not 1
PR port-mips/59342: compat_setjmp.S is confused about delay slots
PR port-mips/59343: compat_sigsetjmp.S: missing RESTORE_GP64


To generate a diff of this commit:
cvs rdiff -u -r1.22 -r1.23 src/sys/arch/mips/mips/compat_13_machdep.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.