Source-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

CVS commit: src/sys/dev/acpi



Module Name:    src
Committed By:   andvar
Date:           Thu Jan  2 16:32:34 UTC 2025

Modified Files:
        src/sys/dev/acpi: acpi_resource.c

Log Message:
acpi(4): validate IO/FixedIO resource base address and length.

Ensure that the base address and length of an IO/FixedIO resource reported by
ACPI do not exceed a 16-bit value plus one (to account for the length).
If an ACPI resource reports a base address of 0xFFFF, it likely indicates that
the device is inoperable or invalid for some reason.

This can cause a kernel with DIAGNOSTIC enabled to panic with the error:
extent_alloc_region: region lies outside extent, even on an otherwise fully
functional system.

In my case, the mpu(4) driver reported a 0xFFFF base address, likely due to
a missing MIDI port or the absence of an actual MIDI UART device,
despite the device being defined as an ACPI resource.

Since this issue affects only DIAGNOSTIC enabled kernels and appears to be rare
(likely caused by a buggy BIOS), I believe that pullups are unnecessary.

lgtm jmcneill


To generate a diff of this commit:
cvs rdiff -u -r1.43 -r1.44 src/sys/dev/acpi/acpi_resource.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.




Home | Main Index | Thread Index | Old Index